*** piggz has quit IRC | 00:04 | |
*** b0unc3_ has joined #maemo-ssu | 00:05 | |
*** b0unc3 has quit IRC | 00:08 | |
*** Per_n900 has quit IRC | 00:08 | |
*** NIN101 has quit IRC | 00:08 | |
*** Per_n900 has joined #maemo-ssu | 00:08 | |
*** b0unc3 has joined #maemo-ssu | 00:12 | |
*** Venemo has quit IRC | 00:15 | |
*** b0unc3_ has quit IRC | 00:15 | |
*** Venemo has joined #maemo-ssu | 00:16 | |
Sc0rpius | so | 00:29 |
---|---|---|
Sc0rpius | should I sent patches to the maillist or request merges directly in gitorious? | 00:29 |
MohammadAG | or request a merge on gitorious and send a link of that to the ML | 00:30 |
Sc0rpius | council@maemo.org? | 00:39 |
MohammadAG | no, maemo-developers ML | 00:40 |
Sc0rpius | I guess I have to subscribe first | 00:41 |
Sc0rpius | well, I requested the merge | 00:55 |
*** Venemo has quit IRC | 01:09 | |
*** merlin1991 has quit IRC | 01:14 | |
*** lardman has quit IRC | 01:21 | |
*** b0unc3 has quit IRC | 01:27 | |
*** b0unc3 has joined #maemo-ssu | 01:29 | |
*** BCMM has quit IRC | 02:08 | |
*** lizardo has joined #maemo-ssu | 02:13 | |
*** lizardo has quit IRC | 02:15 | |
*** andre__ has quit IRC | 02:24 | |
*** M4rtinK has quit IRC | 03:10 | |
*** awwaiid has quit IRC | 03:56 | |
*** awwaiid has joined #maemo-ssu | 03:57 | |
*** b0unc3 has quit IRC | 05:03 | |
*** b0unc3 has joined #maemo-ssu | 05:05 | |
*** anidel has quit IRC | 07:00 | |
*** AcTiVaTe has joined #maemo-ssu | 07:15 | |
*** DocScrutinizer has quit IRC | 07:35 | |
*** DocScrutinizer has joined #maemo-ssu | 07:41 | |
*** Dhraakellian has joined #maemo-ssu | 08:55 | |
*** Sicelo has joined #maemo-ssu | 09:08 | |
*** Sicelo has quit IRC | 09:37 | |
*** Sicelo has joined #maemo-ssu | 09:38 | |
Jaffa | Sc0rpius: Sorry, I was joking about the ML (see maemo-developers). Merge requests are the current best approach | 09:38 |
Jaffa | Sc0rpius: There's a thread about enforcing ML-based code reviews. | 09:40 |
*** villev has joined #maemo-ssu | 09:51 | |
*** villev has quit IRC | 09:52 | |
*** villev has joined #maemo-ssu | 09:52 | |
*** xix has joined #maemo-ssu | 10:49 | |
xix | Hi/Bonjour | 10:49 |
*** psycho_oreos has joined #maemo-ssu | 10:52 | |
*** villev has quit IRC | 11:01 | |
*** andre__ has joined #maemo-ssu | 11:01 | |
*** andre__ has joined #maemo-ssu | 11:01 | |
*** villev has joined #maemo-ssu | 11:01 | |
*** villev has quit IRC | 11:05 | |
*** villev has joined #maemo-ssu | 11:10 | |
Jaffa | xix: Bienvenue | 11:13 |
*** crashanddie has joined #maemo-ssu | 11:31 | |
*** xix has quit IRC | 11:38 | |
*** villev has quit IRC | 11:44 | |
*** villev has joined #maemo-ssu | 11:45 | |
*** b0unc3_ has joined #maemo-ssu | 12:44 | |
*** b0unc3 has quit IRC | 12:47 | |
*** M4rtinK has joined #maemo-ssu | 13:04 | |
*** M4rtinK has quit IRC | 13:12 | |
*** b0unc3 has joined #maemo-ssu | 13:31 | |
*** villev has quit IRC | 13:31 | |
*** b0unc3_ has quit IRC | 13:34 | |
*** villev has joined #maemo-ssu | 13:34 | |
*** Per_n900 has quit IRC | 14:01 | |
*** MohammadAG has quit IRC | 14:03 | |
*** MohammadAG has joined #maemo-ssu | 14:04 | |
*** Per_n900 has joined #maemo-ssu | 14:05 | |
*** Sicelo1 has joined #maemo-ssu | 14:06 | |
*** Sicelo has quit IRC | 14:07 | |
*** Sicelo1 is now known as Sicelo | 14:07 | |
*** MohammadAG has quit IRC | 14:08 | |
*** MohammadAG has joined #maemo-ssu | 14:10 | |
*** MohammadAG has quit IRC | 14:27 | |
*** MohammadAG has joined #maemo-ssu | 14:27 | |
*** NIN101 has joined #maemo-ssu | 14:34 | |
*** lardman|gone is now known as lardman | 14:45 | |
*** psycho_oreos has quit IRC | 14:58 | |
*** MohammadAG has quit IRC | 15:05 | |
*** MohammadAG has joined #maemo-ssu | 15:05 | |
MohammadAG | I'm against alberto's ML suggestions | 15:05 |
MohammadAG | Also, I should start using names instead of nicks in emails | 15:06 |
*** BCMM has joined #maemo-ssu | 15:10 | |
*** Per_n900 has quit IRC | 15:15 | |
*** Per_n900 has joined #maemo-ssu | 15:18 | |
X-Fade | MohammadAG: Ultimately you have developers and maintainers/release managers. A 2 step process for updates to be published. | 15:19 |
X-Fade | As we don't have many people working on it these are one and the same ;) | 15:19 |
*** xix has joined #maemo-ssu | 15:35 | |
*** villev has quit IRC | 15:36 | |
*** lizardo has joined #maemo-ssu | 15:40 | |
*** lardman|home has joined #maemo-ssu | 15:51 | |
* Jaffa would be more persuaded if alberto went through the commits to do and submitted what he'd suggest as changes as a merge request. | 15:51 | |
*** ZogG has quit IRC | 16:08 | |
*** lardman|home has quit IRC | 16:12 | |
*** anidel has joined #maemo-ssu | 16:12 | |
*** ZogG has joined #maemo-ssu | 16:20 | |
*** Sicelo has left #maemo-ssu | 16:33 | |
crashanddie | I loved the "So this is a personal style discussion more than anything else?" "No, not at all, I just cited some examples _I_ would not tolerate had _I_ been given the chance... | 16:39 |
*** xix has quit IRC | 16:51 | |
anidel | but he is right however... these CSSU, for now, are still in "beta" testing.. but at one point they'll reach a customer, an end-user.. and albeit there's no liability here, we still should aim to give 'em the best we can. Having code properly written and patches properly documented, helps debugging, helps fixing, helps improving.. it's more time consuming, but in the long runs it helps. | 17:00 |
*** AcTiVaTe has quit IRC | 17:00 | |
anidel | I think he gave a bit thougher examples of what HE would not have accepted as a patch in a CSSU, but I don't think he's aiming to reach that point | 17:00 |
anidel | just something in between... | 17:00 |
anidel | and I guess that's all we all want, isn't it? | 17:00 |
Jaffa | anidel: Indeed. Just some simple comms approaches would've improved things; rather than starting a thing saying "I'm not slighting X or Y; just the development process [is broken]" | 17:08 |
anidel | well not everyone is good at communicating, but his intention were good anyway... so | 17:16 |
*** merlin1991 has joined #maemo-ssu | 17:18 | |
*** Sicelo has joined #maemo-ssu | 17:26 | |
*** Sicelo has quit IRC | 17:30 | |
Sc0rpius | so | 17:31 |
Sc0rpius | anidel, I showed you last time about your send button disappearing and the commit that was revoked but I think you missed it | 17:31 |
Sc0rpius | http://gitorious.org/community-ssu/modest/commit/f1919bce12cf5cd8fc4f3b0157d847f53e07499b | 17:32 |
Sc0rpius | it was thatone | 17:32 |
Sc0rpius | and I subscribed to the ML and I can see you guys fighting about the review process. | 17:33 |
anidel | why it was reverted? | 17:33 |
Sc0rpius | as you can read there, the main developer of Modest, a year ago, said: | 17:34 |
Sc0rpius | "We won't have this in master" | 17:34 |
anidel | yeah I know.. I wasn't asking you specifically :) | 17:34 |
anidel | weird | 17:34 |
anidel | but it MADE to a PR though | 17:34 |
Sc0rpius | yeah it's weird, it seems he didn't like it. He left it in the 3.4.x branch but getting it out from master is a way to get ridden of it in the next release | 17:35 |
Sc0rpius | and that's exactly what happened, maybe he didn't like it | 17:36 |
Sc0rpius | but we can request a re-merge, in the modest-cssu of course | 17:36 |
anidel | yup.. | 17:37 |
anidel | good catch... | 17:37 |
Sc0rpius | we need to go faster in bug fixes, at least testing/approving them | 17:42 |
*** merlin1991 has quit IRC | 17:50 | |
Jaffa | Sc0rpius: As someone contributing code, your thoughts on code review would be useful. | 17:52 |
Jaffa | I'd like to try gitorious so I can see how it goes; but I'm happy with what MohammadAG wants | 17:52 |
anidel | on a side note, how do we know who has some power on the CSSU decisions and who doesn't? for example for Bug 11839 I just got a comment from Naikel. Now did he just left a comment because he felt so, or is he somehow related to the CSSU S&H ? | 18:00 |
povbot | Bug https://bugs.maemo.org/11839 Show the previous e-mail after deleting an e-mail in VIEW mode | 18:00 |
Sc0rpius | <--- Naikel | 18:03 |
Sc0rpius | you just got a comment from me :P | 18:03 |
Sc0rpius | and like I said there | 18:03 |
Sc0rpius | I tested your patch, and it's nice, and it works, and the GUI and everything | 18:03 |
Sc0rpius | but I was researching other email clients and I think it's a bug, not an enhancement. | 18:03 |
*** BCMM has quit IRC | 18:04 | |
anidel | didn't know :) the point is only "should I consider that suggestion as a way of saying "do that" or is, let's say "just", a comment from someone who thinks it would be better to threat is as a bug and not as an enhancement? | 18:04 |
anidel | exactly | 18:04 |
Sc0rpius | ah good question, but anyway you already did, since the first patch you posted would be the right one if it's considered a bug | 18:05 |
anidel | me too, but now, speaking of "review" processes.. how do we deal with this... | 18:05 |
anidel | at the beginning I fixed "as a bug", but I thought it was an enhancement, rather than a bug fix.. but yeah... | 18:05 |
anidel | my question if not related to my bug and your comment of course.. it's just a general one | 18:06 |
anidel | about defining review procedures .. | 18:07 |
Sc0rpius | yes well | 18:07 |
Sc0rpius | I have that question too | 18:07 |
Sc0rpius | because usually, a lot of people test and vote | 18:07 |
Sc0rpius | but CSSU is not that big | 18:07 |
Sc0rpius | (not yet) | 18:07 |
anidel | indeed | 18:07 |
Sc0rpius | I have soooo many fixes/enhancements to send for Modest | 18:09 |
anidel | do send them | 18:09 |
*** b0unc3_ has joined #maemo-ssu | 18:14 | |
*** M4rtinK has joined #maemo-ssu | 18:15 | |
*** b0unc3 has quit IRC | 18:17 | |
*** Brownout has quit IRC | 18:22 | |
*** Brownout has joined #maemo-ssu | 18:24 | |
*** merlin1991 has joined #maemo-ssu | 18:29 | |
* Jaffa would rather have a patch included and work on the processes iteratively than have people discouaraged *at this stage* | 18:33 | |
Sc0rpius | we're not discouraged | 18:34 |
Sc0rpius | but, have you read the thread of CSSU in tmo? | 18:34 |
andre__ | url? | 18:35 |
Sc0rpius | even though it's testing we should try to avoid so much frustration | 18:35 |
Sc0rpius | so, merging patches blindly is out of the question, right? | 18:35 |
Sc0rpius | we need to test them | 18:35 |
Jaffa | Sc0rpius: Right. | 18:35 |
Sc0rpius | (and a different maillist from the maemo-developers would be nice too hehehe) | 18:36 |
Jaffa | TBH, I think maemo-developers is the best mailing list at the moment. It's supposed to be for the "development of Maemo" (or rather, it was originally). Now it is again :-) | 18:36 |
Sc0rpius | for example, I would like people testing my merge request | 18:37 |
Jaffa | Things to consider: 1) Can we have additional maintainers for the projects under gitorious.org/community-ssu? | 18:37 |
Sc0rpius | I guess I should be sending an email to the maillist for that | 18:37 |
Jaffa | Sc0rpius: Well, that's what the testing repo is for... | 18:37 |
Sc0rpius | well like you said in an email, eventually it'd be reach a maintainer per project | 18:37 |
Jaffa | After some initial tests by you and the maintainer (currently MohammadAG) | 18:37 |
Sc0rpius | "eventually" | 18:37 |
Sc0rpius | do you guys use an IDE for scratchbox or something? | 18:42 |
Sc0rpius | 'cos I really use vi and that's it. | 18:42 |
*** b0unc3_ has quit IRC | 18:43 | |
*** b0unc3 has joined #maemo-ssu | 18:44 | |
anidel | VI is all you need. Is your best friend | 18:56 |
anidel | :p | 18:56 |
Sc0rpius | yeah it has been since like 1989 for me | 18:59 |
Sc0rpius | but I was just wondering if people nowadays use something else | 18:59 |
MohammadAG | Sc0rpius, Qt Creator for anything in Qt, I still use CLI in scratchbox to package and compile apps | 19:03 |
Sc0rpius | nice | 19:03 |
Sc0rpius | I haven't made my first program in QT yet | 19:03 |
MohammadAG | Qt Creator is awesome really | 19:03 |
anidel | have you used other IDEs before? | 19:04 |
Sc0rpius | I have used Eclipse for Java | 19:04 |
Sc0rpius | and it was "ok" | 19:04 |
MohammadAG | no | 19:04 |
anidel | When I used Netbeans or Eclipse I loved them.. but then, I was coming from almost pure terminal development :D | 19:04 |
*** Ulukai has joined #maemo-ssu | 19:05 | |
MohammadAG | I went from gedit to Qt Creator so :P | 19:05 |
anidel | actually I still develop mostly in vi... because there's no vi.. just you and the code.. | 19:05 |
MohammadAG | really if you haven't tried Qt Creator, you're missing out | 19:05 |
anidel | no no I | 19:06 |
anidel | I'm not saying I won't use or won't like it | 19:06 |
anidel | I will, definitely I will | 19:06 |
anidel | it's just that you need to learn to use IT and the toolkit | 19:07 |
*** lardman is now known as lardman|gone | 19:07 | |
Jaffa | The Qt Quick stuff in Qt Creator 2.1 is very cool | 19:07 |
MohammadAG | you don't have to write Qt with Qt Creator | 19:07 |
anidel | I've seen amazing things done with it | 19:07 |
MohammadAG | you can write C/Gtk | 19:08 |
anidel | we'll see when I'll port Xournal to it how far I can go without writing Qt stuff... hopefully far | 19:08 |
* w00t_ waves his little "Qt Fanboy" flag around quietly | 19:09 | |
* anidel doesn't notice a thing.. he's sure is missing something... mmmm | 19:10 | |
w00t_ | :-) | 19:12 |
*** Venemo has joined #maemo-ssu | 19:18 | |
*** Brownout has quit IRC | 19:18 | |
anidel | :-p | 19:21 |
MohammadAG | Sc0rpius, do attachments always work properly after you reversed the commits? | 19:33 |
*** Per_n900 has quit IRC | 19:36 | |
Sc0rpius | yes, always work | 19:36 |
*** b0unc3_ has joined #maemo-ssu | 19:36 | |
Sc0rpius | you can reproduce easily the problem sending email to you and reading it using a Microsoft client | 19:37 |
Sc0rpius | Microsoft will drop the attachments under multipart/alternative | 19:37 |
MohammadAG | I don't use any microsoft clients :P | 19:37 |
Sc0rpius | that's why you never hit the bug I guess | 19:37 |
Sc0rpius | :) | 19:37 |
Sc0rpius | there's NO way to add a "X-My-Custom-Header" in Modest I don't know why it is all there, it wasn't before | 19:38 |
Sc0rpius | maybe the main developer thought of a future feature and implemented all of that to aid that feature we never saw | 19:38 |
Sc0rpius | another way to hit the bug is send mail to you from Modest and see there are two X-Mailer headers | 19:39 |
Sc0rpius | and actually I think they increase everytime you decide not to send the mail and it goes to the Draft folder | 19:39 |
*** b0unc3 has quit IRC | 19:40 | |
Sc0rpius | so you could receive a mail with 10 X-Mailer headers if you abort the composing 10 times heh | 19:40 |
MohammadAG | Sc0rpius, merged the patch | 19:40 |
Sc0rpius | nice :D | 19:40 |
Sc0rpius | now anidel should send his patch, though I think he should send the "bug" fix and not the "enhancement" fix | 19:40 |
Sc0rpius | that is Bug 11839 | 19:41 |
povbot | Bug https://bugs.maemo.org/11839 Show the previous e-mail after deleting an e-mail in VIEW mode | 19:41 |
MohammadAG | Sc0rpius, can be in the next update, I'm pushing thp's patches and your modest ones now | 19:42 |
MohammadAG | actually | 19:42 |
MohammadAG | can you test the deb I have? just to be sure | 19:42 |
Sc0rpius | sure | 19:42 |
*** Brownout has joined #maemo-ssu | 19:45 | |
MohammadAG | Sc0rpius, http://mohammadag.xceleo.org/modest_3.90.7-4_armel.deb | 19:46 |
Sc0rpius | ok | 19:46 |
*** BCMM has joined #maemo-ssu | 19:47 | |
Sc0rpius | ok let's wait I receive the mail | 19:49 |
Sc0rpius | I got it | 19:49 |
Sc0rpius | the attachments are there, let's see all the headers | 19:50 |
Sc0rpius | Content-Type: multipart/mixed; boundary="=-HGV6dz+qMFuHjGt2Zh68" | 19:50 |
Sc0rpius | X-Mailer: Modest 3.90.7 | 19:50 |
Sc0rpius | it works | 19:51 |
Sc0rpius | well we could merge a couple of more fixes | 19:51 |
Sc0rpius | the send button in the scrollable area, that's easy | 19:51 |
Sc0rpius | and the one in Bug 11839 | 19:51 |
povbot | Bug https://bugs.maemo.org/11839 Show the previous e-mail after deleting an e-mail in VIEW mode | 19:51 |
*** wmarone has quit IRC | 19:53 | |
MohammadAG | Sc0rpius, I didn't get merge requests | 19:53 |
Sc0rpius | yeah | 19:53 |
Sc0rpius | 'cos we haven't requested them | 19:53 |
Sc0rpius | :) | 19:53 |
*** wmarone has joined #maemo-ssu | 19:53 | |
Sc0rpius | when's the next update? | 19:54 |
MohammadAG | now :P | 19:54 |
Sc0rpius | then I guess we'll miss those | 19:55 |
MohammadAG | well | 19:55 |
MohammadAG | I can wait an hour | 19:55 |
MohammadAG | haven't started pushing | 19:55 |
Sc0rpius | not enough time to make thorough testing, I read the patches, but never installed them and test them | 19:55 |
Sc0rpius | don't worry, they'll be in the next update. | 19:55 |
MohammadAG | ah | 19:55 |
Sc0rpius | if I'm not 101% sure, I'm not requesting any merge | 19:56 |
MohammadAG | well, we had an update yesterday, and another one today | 19:56 |
Sc0rpius | you think that will piss off people? | 19:56 |
MohammadAG | so I guess we can push them tomorrow | 19:56 |
merlin1991 | MohammadAG, don't push to the builder get the proper tags up so I can write the changelog :D | 19:58 |
*** Ulukai has left #maemo-ssu | 20:00 | |
*** wertzu has joined #maemo-ssu | 20:03 | |
*** Venemo has quit IRC | 20:04 | |
*** wertzu has quit IRC | 20:04 | |
*** Venemo has joined #maemo-ssu | 20:04 | |
*** merlin1991 has quit IRC | 20:06 | |
MohammadAG | merlin1991, I'll get it right this time (but I already pushed to the repo) | 20:06 |
MohammadAG | merlin1991, git tag commit name right? | 20:07 |
*** merlin1991 has joined #maemo-ssu | 20:07 | |
*** mirr0r has quit IRC | 20:08 | |
Sc0rpius | I think I'm hungry | 20:08 |
*** Per_n900 has joined #maemo-ssu | 20:09 | |
MohammadAG | X-Fade, ping | 20:16 |
MohammadAG | isn't bug 11858 just a layout problem? I never tried gtk properly so.. | 20:22 |
povbot | Bug https://bugs.maemo.org/11858 Unexpected repeated button To: | 20:22 |
Sc0rpius | ah we have to fix that too | 20:23 |
Sc0rpius | the button show grow in size and not "repeat" | 20:23 |
Sc0rpius | one giant "To" button, actually if you press it you'll see it's just one button, with the same repeated pixbuf | 20:24 |
MohammadAG | X-Fade, the packages aren't being pushed, or I'm impatient | 20:24 |
MohammadAG | Sc0rpius, the bug existed in Qt apps | 20:25 |
MohammadAG | but not in gtk ones | 20:25 |
Sc0rpius | weird huh? but it exists in Modest | 20:25 |
Sc0rpius | I've confirmed that bug | 20:25 |
MohammadAG | should be a change in the gtk_box_add_widget or sth | 20:25 |
Sc0rpius | yeah I guess, haven't look at it | 20:26 |
Sc0rpius | but I tested it and I confirmed it | 20:26 |
* Sc0rpius takes a quick look | 20:26 | |
MohammadAG | changed it to NEW | 20:26 |
MohammadAG | X-Fade, false alarm :p | 20:26 |
*** marcels has joined #maemo-ssu | 20:27 | |
Sc0rpius | ok the problem I think is: | 20:35 |
Sc0rpius | gtk_widget_set_size_request (label_widget, 148 - MODEST_MARGIN_DOUBLE, -1); | 20:35 |
Sc0rpius | instead of: | 20:35 |
Sc0rpius | gtk_window_set_default_size (label_widget, 148 - MODEST_MARGIN_DOUBLE, -1); | 20:35 |
Sc0rpius | the first one doesn't allow shrinking/growing | 20:35 |
Sc0rpius | the second does | 20:35 |
Sc0rpius | of course, I have to make the patch, test it, etc, etc, etc... | 20:35 |
Sc0rpius | but a quick look makes me think that's the problem | 20:36 |
Sc0rpius | well actually no that won't work | 20:36 |
* Sc0rpius thinks | 20:36 | |
MohammadAG | shouldn't we just use HILDON_FINGER_HEIGHT and make that fixed? | 20:38 |
MohammadAG | or whatever it's called | 20:38 |
Sc0rpius | we need them to grow | 20:38 |
Sc0rpius | and be a giant button when you have several To: lines | 20:38 |
Sc0rpius | abook_button = hildon_gtk_button_new (HILDON_SIZE_FINGER_HEIGHT); | 20:38 |
Sc0rpius | and it actually does that | 20:38 |
Sc0rpius | abook = "address book" | 20:39 |
Sc0rpius | used for To:, Cc: and Bcc: buttons | 20:39 |
Sc0rpius | actually I guess it should be created as HILDON_SIZE_AUTO_HEIGHT | 20:40 |
MohammadAG | no | 20:41 |
MohammadAG | actually | 20:41 |
MohammadAG | maybe, try that | 20:41 |
Sc0rpius | ok lemme try it quickly | 20:41 |
MohammadAG | I thought we'd make it FINGER_HEIGHT and set it to not expand | 20:41 |
Sc0rpius | we want it to expand | 20:42 |
Sc0rpius | works *perfect* with HILDON_SIZE_AUTO_HEIGHT lemme show you a screenshot | 20:42 |
*** Per_n900 has quit IRC | 20:44 | |
Sc0rpius | http://img18.imageshack.us/img18/360/screenshot2011020710433.png | 20:45 |
Sc0rpius | we need the button to grow because it should be one single button for the whole To: addresses | 20:45 |
Sc0rpius | see? | 20:45 |
MohammadAG | that's not hildon-y | 20:45 |
MohammadAG | looks like the gtk-themed button | 20:46 |
Sc0rpius | because the gradient? | 20:46 |
Sc0rpius | the gradient not being present? | 20:46 |
Sc0rpius | I mean how are you telling the difference | 20:47 |
MohammadAG | yes | 20:48 |
Sc0rpius | the other solution is, not to grow the button, just the editable area | 20:48 |
*** merlin1991 has quit IRC | 20:48 | |
MohammadAG | some apps have big buttons and gradient | 20:48 |
MohammadAG | and the* | 20:48 |
Sc0rpius | but that might be a major change since both of them are in just one box | 20:48 |
Sc0rpius | we lose the gradient in HILDON_SIZE_AUTO_HEIGHT, as I quote the hildon documentation: | 20:49 |
MohammadAG | there should be a way to have the gradient | 20:49 |
Sc0rpius | "You should always use the finger or the thumb size, don't use HILDON_SIZE_AUTO_HEIGHT as the outcome is not totally clear " | 20:49 |
Sc0rpius | you can have a big button with gradient, just not shrinkable/growable | 20:50 |
Sc0rpius | and yeah I agree it looks horrible without the gradient | 20:50 |
MohammadAG | I realize they're different, but Qt apps can | 20:51 |
Sc0rpius | I bet | 20:51 |
*** Per_n900 has joined #maemo-ssu | 20:51 | |
Sc0rpius | well then maybe make the button not growable at all., | 20:56 |
anidel | I'm back | 20:56 |
*** marcels has quit IRC | 20:58 | |
Sc0rpius | I'm not sure how to fix it | 21:00 |
*** Per_n900 has quit IRC | 21:01 | |
Sc0rpius | since we don't have gtk_widget_set_vexpand ... | 21:04 |
*** b0unc3 has joined #maemo-ssu | 21:06 | |
anidel | probably using several TO buttons for each e-mail, so replicating the row "TO | <email>" as many times as there are e-mails. One nice improvement would be to be able to "change" that e-mail address with another one from the Contact list when tapping on that particolar TO: | 21:07 |
Sc0rpius | that would be hard, because you would have to modify the "box" widget to add new buttons | 21:07 |
anidel | even though I'd like a way to change those TO: to CC: , when tapping on them... but well | 21:07 |
anidel | is this bug appearing only on the CSSU version of modest? | 21:08 |
Sc0rpius | not sure | 21:08 |
Sc0rpius | I haven't tested the 3.4.8 for this bug | 21:08 |
anidel | k | 21:08 |
*** b0unc3_ has quit IRC | 21:10 | |
Sc0rpius | not present in 3.4.8 | 21:16 |
anidel | interesting | 21:16 |
*** Per_n900 has joined #maemo-ssu | 21:17 | |
MohammadAG | Sc0rpius, not present as in does not expand, or does not make multiple pixmaps? | 21:24 |
anidel | it does not expand. | 21:30 |
Sc0rpius | not expand | 21:31 |
anidel | The text area expands vertically, but the TO remains where it is... | 21:32 |
MohammadAG | then make it not expand :P | 21:32 |
*** BCMM has quit IRC | 21:34 | |
Sc0rpius | yeah I would like to | 21:34 |
MohammadAG | it's easy I think | 21:35 |
MohammadAG | did it once | 21:35 |
MohammadAG | it's in the pack function | 21:35 |
MohammadAG | which file is that window in? | 21:35 |
anidel | modest-msg-edit-window.c I guess | 21:36 |
Sc0rpius | yes | 21:36 |
Sc0rpius | maybe reversing this: | 21:36 |
Sc0rpius | http://gitorious.org/~naikel/community-ssu/naikel-modest-cssu/commit/da157c916d84d3f4eadacb51fb3f1caa33ac22ef | 21:36 |
Sc0rpius | done | 21:41 |
Sc0rpius | it's just a single change: | 21:42 |
anidel | the alignment thingy? | 21:42 |
Sc0rpius | align = gtk_alignment_new (0.0, 0.0, 1.0, 1.0); | 21:42 |
Sc0rpius | to: | 21:42 |
Sc0rpius | lign = gtk_alignment_new (0.0, 0.0, 1.0, 0.0); | 21:42 |
Sc0rpius | yes. | 21:42 |
anidel | yeah I was testing the same change indeed | 21:42 |
Sc0rpius | and it was include in the commit I pasted before, that's when we lost it | 21:42 |
Sc0rpius | if we want to be professional maybe we should put it in the #ifdef MODEST_TOOLKIT_HILDON2 | 21:43 |
Sc0rpius | and using 1.0 in the #else | 21:43 |
Sc0rpius | dunno. | 21:43 |
anidel | let's be :) | 21:43 |
Sc0rpius | like this: http://pastie.org/1538076 | 21:44 |
Sc0rpius | actually it's inversed | 21:45 |
*** Per_n900 has quit IRC | 21:45 | |
Sc0rpius | (it's an ifndef sorry) | 21:46 |
Sc0rpius | it's like this: | 21:46 |
Sc0rpius | http://pastie.org/1538088 | 21:46 |
Sc0rpius | well that fixes it, want a merge request MohammadAG? | 21:46 |
Sc0rpius | (or wanna do it yourself) | 21:47 |
MohammadAG | Sc0rpius, send a merge request, if you can | 21:47 |
Sc0rpius | sure | 21:47 |
Sc0rpius | anidel are you gonna request a merge with your patch or want me to do it? | 21:57 |
Sc0rpius | I mean the newer message after delete/move, that's an important patch for me | 21:58 |
anidel | I would do it, if I knew how.. I am new to GIT | 21:58 |
anidel | also.. about the Settings new button and its translation | 21:59 |
Sc0rpius | you fixed that? I forgot about it, but I guess it's in the en_GB.po | 22:00 |
anidel | it is, but we're not installing the po file | 22:00 |
anidel | I guess we have languages packs? | 22:00 |
Sc0rpius | how so | 22:00 |
*** Venemo has quit IRC | 22:00 | |
Sc0rpius | well I was wondering the same thing, where are the other pos | 22:01 |
anidel | yeah I think in different packages :d | 22:01 |
*** Per_n900 has joined #maemo-ssu | 22:01 | |
Sc0rpius | ii modest-l10n-enus 6.0+r7987+0m5 language files for modest (en_US) | 22:01 |
Sc0rpius | well yeah... | 22:01 |
*** NIN101 has quit IRC | 22:01 | |
*** NIN101 has joined #maemo-ssu | 22:02 | |
anidel | so not sure how to deal with that | 22:02 |
anidel | MohammadAG ? | 22:03 |
Sc0rpius | I guess CVS and SVN will be obsolete in no time (if they are not obsolete already) with this git | 22:04 |
Sc0rpius | I try to like git, but since it's written by Torvalds, I hate it | 22:04 |
MrBawb | Sc0rpius: maybe you'd like hg then | 22:05 |
anidel | never.. many people still lave CVS, many hate GIT, many love or hate SVN.. as usual | 22:05 |
Sc0rpius | that's Mercurial? | 22:06 |
MohammadAG | I thought it wasn't in settings? | 22:06 |
Sc0rpius | it's funny how they named Mercurial "hg" heh | 22:06 |
MrBawb | yeah, hg is the abbreviation of mercury | 22:07 |
*** lcuk has joined #maemo-ssu | 22:09 | |
*** lcuk has quit IRC | 22:09 | |
*** lcuk has joined #maemo-ssu | 22:09 | |
Sc0rpius | yeah hehe | 22:10 |
Sc0rpius | I guess we have time to fix like 2 more Modest bugs | 22:10 |
Sc0rpius | what about the Send button in the scrollable area? don't you miss it? | 22:10 |
anidel | the one at the bottom? | 22:11 |
Sc0rpius | yeah | 22:11 |
Sc0rpius | I can re-add that | 22:11 |
Sc0rpius | I just reapplying a patch | 22:11 |
anidel | yeah I was working on it, then you showed me the reverted GIT change.. | 22:11 |
anidel | yup | 22:11 |
anidel | please :) | 22:11 |
anidel | I was the one asking them to add it in the first place! :D | 22:11 |
anidel | now I'm doing it again :D | 22:11 |
Sc0rpius | have you seen the Passat 2012 commercial? http://www.youtube.com/watch?v=R55e-uHQna0 | 22:12 |
Sc0rpius | take a look | 22:12 |
anidel | the Darth Vader one? | 22:13 |
Sc0rpius | yeah that one! | 22:14 |
anidel | indeed a cool one :D | 22:15 |
MohammadAG | hmm | 22:15 |
MohammadAG | maybe bug 11874 can be fixed easily | 22:15 |
povbot | Bug https://bugs.maemo.org/11874 Impossible to select text once the email is scrolled (similar to Bug 10390) | 22:15 |
MohammadAG | lol @ ad | 22:21 |
Sc0rpius | I can't reproduce that bug | 22:21 |
Sc0rpius | I can select just fine | 22:21 |
MohammadAG | scroll down | 22:22 |
Sc0rpius | unless... it's at the end | 22:22 |
MohammadAG | then hold ctrl and try to select | 22:22 |
Sc0rpius | actually I think is shift ;) | 22:22 |
MohammadAG | it'll select the paragraph above the one you selected | 22:22 |
Sc0rpius | holding shift, not ctrl | 22:22 |
MohammadAG | shift, my bad | 22:22 |
Sc0rpius | yeah the reporter also said ctrl | 22:22 |
Sc0rpius | I can see it now | 22:23 |
anidel | indeed.. it seems like the virtual cursor position goes weird? | 22:23 |
MohammadAG | yeah | 22:24 |
MohammadAG | see the bug he linked to | 22:24 |
MohammadAG | nokia already fixed it | 22:24 |
Sc0rpius | does it happen in 3.4.8? | 22:24 |
Sc0rpius | if Nokia fixed, I wonder where | 22:25 |
Sc0rpius | 'cos it looks like it happens in 3.4.8 (PR1.3) too | 22:26 |
anidel | no it works fine in 3.4.8 | 22:26 |
Sc0rpius | really? | 22:26 |
anidel | at least in the SDK | 22:26 |
Sc0rpius | root:/root# dpkg -i modest_3.4.8+0m5_armel.deb | 22:26 |
Sc0rpius | we'll see... | 22:26 |
anidel | were it wasn't working on 3.90 | 22:26 |
Sc0rpius | it is still present in my modest 3.4.8 | 22:27 |
MohammadAG | http://gitorious.org/modest/modest/commit/b38bb395947076883ccb68e800b49e8dd68fdc7b | 22:27 |
anidel | http://gitorious.org/modest/modest/commit/b38bb395947076883ccb68e800b49e8dd68fdc7b | 22:27 |
anidel | ops | 22:27 |
anidel | :D | 22:27 |
anidel | yeah | 22:27 |
anidel | what? | 22:27 |
anidel | really? not for me here | 22:27 |
* Sc0rpius killall modest and try again | 22:29 | |
anidel | and that patch is not in modest 3.90 . . wonder what happened | 22:29 |
Sc0rpius | yeah it does not happen in 3.4.8 | 22:29 |
Sc0rpius | I always forget the killall part | 22:29 |
Sc0rpius | well you have to reapply that patch then MohammadAG | 22:29 |
*** crashanddie_ has joined #maemo-ssu | 22:30 | |
*** crashanddie_ has joined #maemo-ssu | 22:30 | |
anidel | well if that's the fix, it's easy to reapply, but I wonder why it was reverted | 22:30 |
anidel | where it was lost... | 22:30 |
*** b0unc3_ has joined #maemo-ssu | 22:33 | |
*** b0unc3 has quit IRC | 22:37 | |
Sc0rpius | it was lost when non Hildon2 people started to contribute to 3.90.x branch | 22:39 |
Sc0rpius | I wonder who those are, N800 users? | 22:39 |
Sc0rpius | I reapplied the patch for the send button | 22:49 |
Sc0rpius | it only appears when the mail is scrolled | 22:49 |
Sc0rpius | was it like that before? | 22:49 |
Sc0rpius | if the mail is shorter than the 4 or 5 lines the editable field has at the beginning, it's not shown | 22:50 |
MohammadAG | yes | 22:50 |
Sc0rpius | another question | 22:50 |
Sc0rpius | if I have faster application manager installed, I stop receiving OTA updates? | 22:50 |
Sc0rpius | 'cos I haven't received any and I receive them in scratchbox | 22:50 |
*** Ulukai has joined #maemo-ssu | 22:52 | |
MohammadAG | I haven't included anything that would intentionally mess up fapman | 22:55 |
MohammadAG | but fapman copies lists to /opt/fapman, doesn't use the same ones HAM uses | 22:55 |
Sc0rpius | haha in the comments of the ad: "hahaa The Dad thinks he started the car. :)" | 22:57 |
anidel | ahah | 22:59 |
Sc0rpius | well I tested the button in the scrollable area | 23:06 |
Sc0rpius | it works | 23:06 |
Sc0rpius | so here comes the merge | 23:06 |
anidel | great! | 23:06 |
Sc0rpius | well I hope I did the merge right | 23:14 |
Sc0rpius | I mean the merge request | 23:14 |
Jaffa | Sc0rpius: Does the same patch add the Ctrl-Enter to send a mail? I can imagine that being rejected by the purist master as well (given all the other users modest has *cough*) | 23:20 |
MohammadAG | Sc0rpius, looks about right to me | 23:22 |
Sc0rpius | Ctrl-Enter? | 23:23 |
Sc0rpius | I haven't tested that but I don't think so... | 23:24 |
Sc0rpius | the scroll bug should fix a lot of ANNOYING stuff while testing Modest in scratchbox | 23:24 |
Sc0rpius | merge that :) | 23:25 |
Sc0rpius | somehow I feel sad I don't receive the OTA updates | 23:25 |
anidel | wasn't CTRL-ENTER always there? | 23:26 |
MohammadAG | src/widgets/modest-msg-edit-window.c: | 23:37 |
MohammadAG | changing mcen_ia_select_attachment_title to mcen_ti_select_attachment_title should fix bug 11835 | 23:37 |
povbot | Bug https://bugs.maemo.org/11835 Logical ID shown / Translation missing for "Add attachment" dialog title in Modest | 23:37 |
anidel | what do we do when we add a new translation? | 23:38 |
anidel | I mean a new text | 23:38 |
MohammadAG | I'm not sure | 23:40 |
MohammadAG | timeless_mbp should know | 23:40 |
MohammadAG | but we're going to need to update a number of packages | 23:40 |
Sc0rpius | maybe my fapman (BAD name for a software) doesn't have the CSSU repo configured | 23:45 |
MohammadAG | probably yeah | 23:48 |
MohammadAG | go to repository settings, tap title bar and reimport settings | 23:48 |
Sc0rpius | ok I just added the repo, let's see if I get an update now | 23:48 |
MohammadAG | Jaffa, do you know what change folder should say? | 23:48 |
Sc0rpius | oh :( | 23:48 |
Sc0rpius | I added it manually! | 23:48 |
MohammadAG | heh | 23:48 |
Sc0rpius | didn't knew there was an import feature | 23:48 |
Sc0rpius | know | 23:49 |
MohammadAG | I ran across it in fapman's code, didn't know about it before | 23:49 |
Sc0rpius | you should do this | 23:49 |
Sc0rpius | apt-get -d install modest=3.4.8+0m5 | 23:50 |
Sc0rpius | and then | 23:50 |
Sc0rpius | mv /opt/var/cache/apt/archives/modest* <wherever> | 23:50 |
Sc0rpius | and have that .deb around | 23:50 |
Sc0rpius | you can install it and reinstall 3.90.7 a zillion times, nothing happens | 23:50 |
Sc0rpius | that's what I do when I want to check something in 3..8 | 23:51 |
Sc0rpius | 3.4.8 | 23:51 |
Sc0rpius | well my "tree view" mode is almost ready | 23:52 |
Sc0rpius | I have to fix a couple of bugs | 23:53 |
Sc0rpius | after that we can do the offline reading | 23:53 |
Sc0rpius | or IMAP IDEL | 23:53 |
Sc0rpius | IDLE | 23:53 |
*** lizardo has quit IRC | 23:55 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!