*** tg has quit IRC | 00:17 | |
*** tg has joined #maemo-ssu | 00:34 | |
DocScrutinizer05 | ~dict plow | 00:36 |
---|---|---|
infobot | Dictionary 'plow' (1 of 8): \Plow\, Plough \Plough\ (plou), v. i. To labor with, or as with, a plow; to till or turn up the soil with a plow; to prepare the soil or bed for anything. --Shak. [1913 Webster] Doth the plowman plow all day to sow ? --Isa. xxviii. 24. [1913 Webster] Plowable. | 00:36 |
*** andre__ has quit IRC | 00:59 | |
*** BCMM has joined #maemo-ssu | 01:32 | |
*** joshgillies has joined #maemo-ssu | 03:06 | |
*** joshgillies has quit IRC | 03:15 | |
*** andre__ has joined #maemo-ssu | 03:16 | |
*** andre__ has joined #maemo-ssu | 03:16 | |
*** M4rtinK has quit IRC | 04:01 | |
*** NIN101 has quit IRC | 04:02 | |
*** kolp has quit IRC | 04:08 | |
*** arcean has quit IRC | 04:09 | |
*** AndrewX192 has quit IRC | 04:34 | |
*** AndrewX192 has joined #maemo-ssu | 04:34 | |
*** AndrewX192 has joined #maemo-ssu | 04:34 | |
*** AndrewX192 has quit IRC | 04:41 | |
*** AndrewX192 has joined #maemo-ssu | 04:41 | |
*** AndrewX192 has joined #maemo-ssu | 04:41 | |
*** AndrewX192_ has joined #maemo-ssu | 04:46 | |
*** AndrewX192_ has joined #maemo-ssu | 04:46 | |
*** AndrewX192 has quit IRC | 04:47 | |
*** AndrewX192_ has quit IRC | 04:48 | |
*** AndrewX192 has joined #maemo-ssu | 04:51 | |
*** BCMM has quit IRC | 04:52 | |
*** AndrewX192 has quit IRC | 04:56 | |
*** AndrewX192 has joined #maemo-ssu | 04:57 | |
*** AndrewX192 has joined #maemo-ssu | 04:57 | |
*** AndrewX192 has quit IRC | 04:58 | |
*** AndrewX192 has joined #maemo-ssu | 05:02 | |
*** AndrewX192 has joined #maemo-ssu | 05:07 | |
*** AndrewX192 has joined #maemo-ssu | 05:07 | |
*** AndrewX192_ has joined #maemo-ssu | 05:30 | |
*** AndrewX192_ has joined #maemo-ssu | 05:30 | |
*** AndrewX192_ has quit IRC | 05:32 | |
*** AndrewX192 has quit IRC | 05:34 | |
*** AndrewX192 has joined #maemo-ssu | 05:35 | |
*** amiconn has quit IRC | 05:53 | |
*** amiconn_ has joined #maemo-ssu | 05:53 | |
*** amiconn_ is now known as amiconn | 05:53 | |
jon_y | merlin1991: ping | 05:56 |
*** DocScrutinizer05 has quit IRC | 06:03 | |
*** DocScrutinizer05 has joined #maemo-ssu | 06:03 | |
jon_y | merlin1991: did you ever encounter something about a missing libfakeroot-sysv.so when doing http://wiki.maemo.org/CSSU-thumb_toolchain_setup_%28gcc4.7.2-linaro%29 ? | 06:03 |
*** nox- has quit IRC | 06:10 | |
merlin1991 | nope, but I never set one up | 06:14 |
merlin1991 | freemangordon: ^^ | 06:14 |
*** Martix has quit IRC | 06:27 | |
*** _xnt14 has joined #maemo-ssu | 06:36 | |
jon_y | merlin1991: I copied the so from FREMANTLE_ARMEL | 06:44 |
jon_y | no idea if it is OK | 06:44 |
jon_y | merlin1991: also, is there a way for scratchbox to access outside the chroot? | 06:47 |
merlin1991 | nope | 07:18 |
*** dhbiker has joined #maemo-ssu | 08:56 | |
jon_y | oh haha wow, I've been building the kernel wrong all these time | 09:21 |
jon_y | need to extract kernel sources first into the git checkout | 09:21 |
jon_y | nothing about that in the README | 09:21 |
*** FIQ has quit IRC | 10:04 | |
*** jonwil has joined #maemo-ssu | 10:29 | |
*** Estel_ has joined #maemo-ssu | 11:12 | |
*** Estel_ has quit IRC | 11:12 | |
*** Estel_ has joined #maemo-ssu | 11:12 | |
*** Estel_ is now known as edchngtf | 11:15 | |
*** edchngtf is now known as Estel_ | 11:15 | |
*** Estel_ has quit IRC | 11:16 | |
*** M4rtinK has joined #maemo-ssu | 12:29 | |
*** freemangordon has quit IRC | 12:29 | |
*** NIN101 has joined #maemo-ssu | 13:03 | |
*** BCMM has joined #maemo-ssu | 14:05 | |
*** arcean has joined #maemo-ssu | 14:21 | |
*** freemangordon has joined #maemo-ssu | 14:28 | |
freemangordon | merlin1991: x86 | 14:30 |
*** kolp has joined #maemo-ssu | 14:41 | |
*** luf has joined #maemo-ssu | 14:46 | |
luf | freemangordon, merlin1991: what about thle libxml2 merge request? I think we agreed it's bug and should be fixed. | 14:59 |
luf | https://gitorious.org/community-ssu/libxml2/merge_requests/1 | 14:59 |
DocScrutinizer05 | ((is there a way for scratchbox to access outside the chroot?)) depends on definition of "access". You can do all sorts of wget apt-get etc. You also can bindmount dirs form host into chroot, that's how a chroot works | 15:03 |
DocScrutinizer05 | actually SB can do apt-get only because host's /dev is bindmounted into the chroot | 15:04 |
DocScrutinizer05 | those bindmounts are also the reason why it's a VERY BAD idea to rm -rf /scratchbox | 15:05 |
DocScrutinizer05 | ask mohammad if you wanna know how bad an idea that is | 15:05 |
jon_y | DocScrutinizer05: I forgot about bind mount | 15:20 |
luf | gregoa: ping | 15:30 |
gregoa | luf: You sent me a contentless ping. This is a contentless pong. Please provide a bit of information about what you want and I will respond when I am around. | 15:30 |
luf | I built libxml2 deb package and it put into depends (using shlibs) zlib1g (>= 1:1.2.1). But I patch it and the required version of zlib1g should be 1.2.3. I don't see where the shlibs takes the 1.2.1 version. | 15:32 |
luf | gregoa: ^^^ | 15:32 |
*** arcean_ has joined #maemo-ssu | 16:17 | |
*** arcean_ has quit IRC | 16:18 | |
*** arcean_ has joined #maemo-ssu | 16:18 | |
*** zogg_ has joined #maemo-ssu | 16:19 | |
*** arcean has quit IRC | 16:21 | |
*** zogg__ has quit IRC | 16:21 | |
*** arcean has joined #maemo-ssu | 16:23 | |
*** arcean_ has quit IRC | 16:25 | |
*** Martix has joined #maemo-ssu | 16:53 | |
gregoa | luf: zlib1g has a shlibs file that says: "libz 1 zlib1g (>= 1:1.2.1)" and that gets inserted in your libxml2 builg via the "${shlib:Depends}" in debian/control. if you need 1.2.3, then just adding "zlib1g (>= 1:1.2.3)" to the Depends line in debian/control should be enough. (or bumping the shlibs in zlib source package and rebuild and build libxml2 against that one) | 17:13 |
*** Martix has quit IRC | 17:17 | |
*** arcean_ has joined #maemo-ssu | 17:30 | |
freemangordon | luf: https://gitorious.org/community-ssu/libpng | 17:38 |
*** arcean_ has quit IRC | 17:38 | |
luf | freemangordon: coool | 17:53 |
*** jonwil has quit IRC | 17:53 | |
luf | freemangordon: We need to revert commits with the NEON opts I added. | 17:54 |
freemangordon | luf: I am testing now with test suite on png website, so far so good | 17:54 |
freemangordon | luf: no, my changes are on top of those | 17:54 |
freemangordon | luf: BTW I don;t guarantee there won;t be some buffer overflow, please check aligment part :D | 17:55 |
luf | Ahhh I see. | 17:55 |
freemangordon | luf: well, it should be ok, but i'll prefer another one to review it | 17:56 |
freemangordon | *i'd | 17:56 |
luf | freemangordon, merlin1991: what about thle libxml2 merge request? I think we agreed it's bug and should be fixed. | 17:59 |
freemangordon | I am ok | 18:00 |
freemangordon | but only merlin1991 can merge | 18:00 |
luf | ok. | 18:00 |
freemangordon | luf: BTW libpng neon patch can be used without alignment part, but performance is worse | 18:02 |
freemangordon | now it scores 2.220, unaligned ~2.400 | 18:03 |
luf | Nice. | 18:03 |
luf | freemangordon: png_read_filter_row: unsigned int bpp = (png_ptr->pixel_depth + 7) >> 3; - what does it do? | 18:14 |
freemangordon | calculates bytes per pixel | 18:14 |
freemangordon | but htis is original code | 18:14 |
luf | I see. | 18:14 |
luf | freemangordon: did you add prev_row to the struct? | 18:16 |
freemangordon | no | 18:16 |
freemangordon | I didn't touch ABI | 18:16 |
luf | I see stupid question ... | 18:16 |
luf | freemangordon: just one thing. 15 upstream has png_ptr->old_prev_row_size = row_bytes + 64; below row_buf setting. I see you keep it above ... | 18:21 |
luf | s/old_prev_row_size/old_big_row_buf_size/ | 18:22 |
infobot | luf meant: freemangordon: just one thing. 15 upstream has png_ptr->old_big_row_buf_size = row_bytes + 64; below row_buf setting. I see you keep it above ... | 18:22 |
freemangordon | luf: lemme check | 18:28 |
luf | Also I don't think it's good to set old_prev_row_size prior to prev_row allocation. | 18:29 |
luf | I think also prev_row should be 16-bit aligned. | 18:29 |
luf | Based on libpng15 code: png_ptr->row_buf = temp - extra - 1/*filter byte*/; png_ptr->prev_row = temp - extra - 1/*filter byte*/; | 18:30 |
freemangordon | luf: your first wuestio: it does not really matter which one will be set first | 18:30 |
freemangordon | *question | 18:30 |
freemangordon | luf: prev_row alignment is done in real-time, that was the hack I was talking aboot | 18:31 |
freemangordon | upstream 15 has an additional struct member to keep unaligned pointer | 18:31 |
freemangordon | we don't :) | 18:31 |
freemangordon | so I keep unaligned pointer and calculate/pass aligned when needed | 18:32 |
freemangordon | a bit of overhead, but no option there aiui | 18:32 |
freemangordon | not that I like that much :D | 18:33 |
luf | So row_bytes is always 16-bit aligned? | 18:33 |
freemangordon | no | 18:33 |
freemangordon | aiui we alloc row_bytes+64 | 18:33 |
freemangordon | that's called big_row_buf or smtg | 18:34 |
freemangordon | row pointer is aligned within this buffer | 18:34 |
freemangordon | so we have padding before and after the real row | 18:35 |
freemangordon | I am not sure i fully understand why this padding is needed, that's why i wanted a code review | 18:35 |
*** dhbiker has quit IRC | 18:36 | |
freemangordon | valgrind reports no bad memory access, no memleaks :) | 18:38 |
*** dhbiker has joined #maemo-ssu | 18:38 | |
luf | what does png_memset_check do? | 18:41 |
freemangordon | NFC, but I gues it does memset :D | 18:43 |
luf | So what's the reason to align16 in png_mem_check? | 18:45 |
luf | I think it's a bug. | 18:45 |
freemangordon | luf: which line? | 18:45 |
luf | 3179 | 18:46 |
freemangordon | luf: png_memset_check(png_ptr, align16(png_ptr->prev_row), 0, | 18:46 |
freemangordon | png_ptr->rowbytes + 1); | 18:46 |
freemangordon | luf: that code? | 18:46 |
luf | yes. | 18:47 |
freemangordon | no, it is ok, we don't need the whole buffer zeroed | 18:47 |
freemangordon | only the part that is used | 18:47 |
luf | Yeah allocated is rowbytes+64 so it doesn't overflow. | 18:48 |
freemangordon | png_ptr->rowbytes is the "real" row bytesize, not the "big buffer" size | 18:48 |
luf | I don't see why the buffer around is needed. But I see no problem in you code. | 18:50 |
luf | Just one more question. Why you changed if ((png_uint_32)row_bytes + 1 > (png_uint_32)65536L) ? | 18:50 |
luf | I see no reason for such change. | 18:51 |
freemangordon | luf: aiui I think the padding is just in case :D | 18:57 |
freemangordon | luf: which line is that change? | 18:58 |
freemangordon | luf: BTW 64 bytes is a bit of overkill, upstream 1.5 use 48 | 18:59 |
freemangordon | luf: re why i changed ^^^ - aiui this code becomes redundant, TBH I don;t see a reason for it to be there even in not-patched version | 19:01 |
freemangordon | *non-patched | 19:01 |
freemangordon | luf: results for http://en.wikipedia.org/wiki/File:PNG_transparency_demonstration_2.png - http://pastebin.com/UYvdgcsb | 19:09 |
freemangordon | impressive | 19:09 |
kerio | heh | 19:11 |
kerio | do the test on the true transparent one | 19:11 |
freemangordon | kerio: wanna do it yourself? i'll upload the binaries | 19:16 |
kerio | is the thumby deb for libpng somewhere? | 19:16 |
freemangordon | just a minute | 19:17 |
freemangordon | kerio: http://merlin1991.at/~freemangordon/libpng/ | 19:18 |
freemangordon | .deb is thumb-compiled, despite the name | 19:19 |
freemangordon | kerio: transparency shhould not affect decoding time | 19:22 |
luf | freemangordon: You're right. That code has to write some drunken dev. As "Row has too many bytes to allocate in memory." is behind some memory (re)allocation :D | 19:23 |
luf | freemangordon: Frommy POV the align part is ok. | 19:24 |
luf | merlin1991: ping | 19:26 |
luf | freemangordon: more interesting should be ARM againist NEON with same thumb/non-thumb and gcc. | 19:28 |
luf | However 30% speed up is nice ;) | 19:28 |
kerio | freemangordon: it's ok if pngtest.png and pngout.png are different, right? | 19:29 |
luf | kerio: it should be ... due to zlib etc. | 19:29 |
luf | kerio: let's try rename the pngout.png and test it on that new ;) | 19:31 |
freemangordon | luf: what do you mean ARM against NEON? | 19:32 |
luf | http://pastebin.com/UYvdgcsb | 19:32 |
luf | I see ARM, gcc 4.2.1 vs NEON+THUMB, gcc 4.7.2: | 19:33 |
kerio | CPU time used = 31.420 seconds (decoding 2.370, encoding 29.040 , other 0.010 seconds) | 19:33 |
freemangordon | luf: THUMB makes almost no difference | 19:34 |
kerio | hold on, i already had a thumby one | 19:34 |
freemangordon | see encoding times | 19:34 |
freemangordon | kerio: yes | 19:34 |
luf | freemangordon: and different gcc also? | 19:34 |
freemangordon | looks like | 19:34 |
luf | ok. | 19:34 |
kerio | CPU time used = 30.800 seconds (decoding 1.580, encoding 29.170 , other 0.050 seconds) | 19:35 |
kerio | holy balls | 19:35 |
kerio | freemangordon: what's this new libpng? | 19:35 |
kerio | NEONized one? | 19:35 |
freemangordon | luf: why don't you test it, pngtest binary is here http://merlin1991.at/~freemangordon/libpng/ | 19:35 |
freemangordon | kerio: yes | 19:35 |
luf | kerio: yes NEONized + memory alignment | 19:35 |
kerio | thumbify it, too! | 19:35 |
freemangordon | it is thumbified | 19:36 |
*** _xnt14 has quit IRC | 19:36 | |
luf | freemangordon: I'm still running non-thumb version. | 19:36 |
freemangordon | luf just build the .deb dammit :P | 19:36 |
freemangordon | luf: ok, i'll build it for you | 19:36 |
freemangordon | hold on a minute | 19:37 |
luf | BTW I see several reboots on my dev N900 yesterday. I installed tklocks and others from cssu-devel. | 19:37 |
luf | freemangordon: don't do it. | 19:37 |
luf | I'm leaving now ... | 19:37 |
freemangordon | luf: reboots? | 19:37 |
freemangordon | do you have sp-rich-core installed? | 19:37 |
freemangordon | luf: before you leave | 19:38 |
luf | freemangordon: I have to leave now. I'll continue later or tomorrow. | 19:38 |
freemangordon | where is neon-patched zlib? | 19:38 |
freemangordon | ok | 19:38 |
luf | No I don't have. | 19:39 |
freemangordon | ok | 19:39 |
luf | You know where is the source. | 19:39 |
luf | http://merlin1991.at/~luf | 19:39 |
luf | http://merlin1991.at/~luf/zlib/source/ | 19:39 |
luf | BTW today's benchmarks showed me less improvement zlib ... | 19:40 |
*** luf has quit IRC | 19:41 | |
*** arcean has quit IRC | 19:43 | |
*** dafox has joined #maemo-ssu | 19:56 | |
kerio | freemangordon: btw, /dev/shm is neat to do tests | 19:57 |
*** MrPingu has joined #maemo-ssu | 20:11 | |
*** Martix has joined #maemo-ssu | 20:52 | |
*** Martix has quit IRC | 20:57 | |
*** Martix has joined #maemo-ssu | 20:58 | |
*** arcean has joined #maemo-ssu | 21:28 | |
*** arcean has quit IRC | 22:08 | |
*** arcean has joined #maemo-ssu | 22:08 | |
*** MrPingu has quit IRC | 22:19 | |
*** andre__ has quit IRC | 22:19 | |
*** Skry has quit IRC | 22:19 | |
*** MrPingu has joined #maemo-ssu | 22:19 | |
*** andre__ has joined #maemo-ssu | 22:19 | |
*** Skry has joined #maemo-ssu | 22:25 | |
*** Skry has quit IRC | 22:37 | |
*** Skry has joined #maemo-ssu | 22:38 | |
*** dhbiker has quit IRC | 23:09 | |
*** joshgillies has joined #maemo-ssu | 23:37 | |
*** Oposum has joined #maemo-ssu | 23:59 |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!