Changeset 245

Timestamp:

01/05/07 03:25:05 (5 years ago)

Author:

mg

Message:

Change the way missile launch sound effects work, to be more like the others.
Fixes a bug where you would hear launch sounds when you pressed the fire key
while your ship was dead.

Location:

trunk/src/pyspacewar

Files:

• ui.py (modified) (2 diffs)
• world.py (modified) (2 diffs)

trunk/src/pyspacewar/ui.py

@@ -2011 +2011 @@
         self.ships = self.game.ships
         for ship in self.ships:
+            ship.launch_effect = self.launch_effect_Ship
             ship.bounce_effect = self.bounce_effect_Ship
             ship.hit_effect = self.hit_effect_Ship
@@ -2270 +2271 @@
         if not self.ai_controlled[player_id]:
             self.ships[player_id].launch()
+
+    def launch_effect_Ship(self, ship, obstacle):
+        """Play a sound effect when the player's ship bounces off something."""
+        player_id = self.ships.index(ship)
+        if not self.ai_controlled[player_id]:
             self.fire_sound.play()
 

trunk/src/pyspacewar/world.py

@@ -556 +556 @@
         self.dead = False
         self.spawn_time = 0 # the value of world.time when last respawned
+        self.launch_effect = None
         self.hit_effect = None
         self.explode_effect = None
@@ -689 +690 @@
         self.velocity -= recoil
         self.world.add(missile)
+        if self.launch_effect:
+            self.launch_effect(self, missile)