| *** Pali has quit IRC | 00:28 | |
| Raimu | Yeah, it was 10 hours to go but I guess the hour changed at a funny point. | 00:37 |
|---|---|---|
| *** dhbiker has joined #maemo-ssu | 00:44 | |
| sixwheeledbeast | weird | 00:45 |
| *** hbib has quit IRC | 00:48 | |
| *** KenYoung has joined #maemo-ssu | 00:54 | |
| *** LauRoman has joined #maemo-ssu | 01:13 | |
| DocScrutinizer05 | hihi | 01:16 |
| DocScrutinizer05 | this happens when coder doesn't obey one of golden rules: always call timing/metering functions only once, in an atomic way, then parse result and store to local vars | 01:18 |
| DocScrutinizer05 | if you however do crimes like printf("time: %2d:%2d", ftime() / 3600, ftime() - (ftime() / 3600)) [or similar] then you get results like the one sixwheeledbeast reported above | 01:24 |
| KenYoung | That's *really* bad code. | 01:25 |
| DocScrutinizer05 | s@ftime() - (ftime() / 3600)@(ftime % 60)/60 | 01:25 |
| *** okias has quit IRC | 01:25 | |
| DocScrutinizer05 | KenYoung: it's incorrect, but even when it was correct it still would be pretty BAD | 01:26 |
| DocScrutinizer05 | ftime() returns seconds,milliseconds since epoch, so the code above is garbage, but I just tried do illustrate something | 01:27 |
| *** M4rtinK has joined #maemo-ssu | 01:29 | |
| DocScrutinizer05 | actually it *returns* always 0 | 01:29 |
| *** okias has joined #maemo-ssu | 01:29 | |
| DocScrutinizer05 | the point however is: you NEVER call a readout function of a dynamic value multiple times. You always call it *once* and store the returned value to a local var | 01:32 |
| *** okias has joined #maemo-ssu | 01:32 | |
| DocScrutinizer05 | obviously the coder of the app that created that notifier sixwheeledbeast seen didn't know that | 01:32 |
| DocScrutinizer05 | it could even get worse when the app hits a microsecond earlier then it may display 10:60 instead 10:00, a bit later and it displays 9:00 instead 10:00 | 01:35 |
| DocScrutinizer05 | on driver level when you can't do atomic reads (e.g. on cmos clock) you do two reads of all registers and compare. If they differ you read a third time, and so on | 01:36 |
| *** kolp has quit IRC | 01:43 | |
| *** obiwlan has quit IRC | 01:48 | |
| *** M4rtinK has quit IRC | 01:49 | |
| *** obiwlan has joined #maemo-ssu | 01:50 | |
| *** amizraa has joined #maemo-ssu | 01:59 | |
| *** Martix has joined #maemo-ssu | 02:34 | |
| *** okias has quit IRC | 02:45 | |
| *** Martix has quit IRC | 02:48 | |
| *** nox- has quit IRC | 02:57 | |
| *** DrCode has quit IRC | 03:07 | |
| *** LauRoman has quit IRC | 03:13 | |
| *** DrCode has joined #maemo-ssu | 03:15 | |
| *** dos1 has quit IRC | 04:31 | |
| *** amiconn_ has joined #maemo-ssu | 05:52 | |
| *** amiconn has quit IRC | 05:52 | |
| *** amiconn_ is now known as amiconn | 05:52 | |
| *** M13 has joined #maemo-ssu | 06:33 | |
| *** trx has quit IRC | 07:05 | |
| *** KenYoung has quit IRC | 07:54 | |
| *** oldtopman has quit IRC | 08:27 | |
| *** Pali has joined #maemo-ssu | 08:35 | |
| *** Pali has quit IRC | 09:18 | |
| *** LauRoman has joined #maemo-ssu | 09:24 | |
| sixwheeledbeast | DocScrutinizer05: Raimu spotted it, I thought it would be impossible to see. However as you point out bad coding somewhere which I guess many will be unsurprised | 10:00 |
| *** M13 has quit IRC | 10:08 | |
| Raimu | yup | 10:15 |
| DocScrutinizer05 | my fault | 10:23 |
| Raimu | That code should be revisited considering it's in a CSSU replacement block, but it's a relatively "huh." level thing, thankfully caught. | 10:24 |
| *** LauRoman has quit IRC | 10:37 | |
| *** Martix has joined #maemo-ssu | 10:46 | |
| *** trx has joined #maemo-ssu | 10:59 | |
| *** kolp has joined #maemo-ssu | 11:00 | |
| *** chem|st_ is now known as chem|st | 11:03 | |
| *** Martix has quit IRC | 11:15 | |
| DocScrutinizer05 | in which component is this? | 11:17 |
| *** Martix has joined #maemo-ssu | 11:18 | |
| *** tom_ has quit IRC | 11:20 | |
| freemangordon | merlin1991: going to push libglib in -devel, should I add +0cssu0 suffix to the version? | 11:23 |
| *** Martix has quit IRC | 11:24 | |
| *** RST38h has quit IRC | 11:50 | |
| *** RST38h has joined #maemo-ssu | 11:50 | |
| *** M4rtinK has joined #maemo-ssu | 11:54 | |
| *** Martix has joined #maemo-ssu | 12:08 | |
| *** Pali has joined #maemo-ssu | 12:15 | |
| *** arcean has joined #maemo-ssu | 12:19 | |
| *** tom__ has joined #maemo-ssu | 12:20 | |
| *** trx has quit IRC | 12:35 | |
| *** lizardo has joined #maemo-ssu | 12:35 | |
| *** delphi has joined #maemo-ssu | 12:35 | |
| *** Martix_ has joined #maemo-ssu | 12:37 | |
| *** Martix has quit IRC | 12:40 | |
| *** Martix_ has quit IRC | 12:45 | |
| DocScrutinizer05 | DANG, seems MohammadAG is absolute top in Itt-thanks (karma) even before qgil, texrat, stskeeps, freemangordon | 12:57 |
| DocScrutinizer05 | :-D | 12:57 |
| DocScrutinizer05 | but wait, I'm coming | 12:58 |
| DocScrutinizer05 | http://maemo.org/profile/list/category/itt_thanks/ | 12:58 |
| DocScrutinizer05 | i'm in good neighbourhood of Kash and Andrew, but we're hunting E*_ :-O | 13:00 |
| DocScrutinizer05 | Pali: I probably should style-prrofread your tmo posts ;-) otherwise E*_ will leave you behind | 13:01 |
| Raimu | DocScrutinizer05: Pretty sure the 9:60 bug is in clock-ui | 13:23 |
| *** Martix_ has joined #maemo-ssu | 13:28 | |
| *** Martix_ has quit IRC | 13:33 | |
| *** Martix_ has joined #maemo-ssu | 13:35 | |
| sixwheeledbeast | Raimu: clock-ui or open source qt replacement clock-ui? | 13:39 |
| *** delphi is now known as trx | 13:39 | |
| * DocScrutinizer05 senses a fundamental problem in maemo: missing peer review on source level, of *all* code before it hits the user | 13:40 | |
| DocScrutinizer05 | pretty unusual and a nogo for industrial grade software - like original maemo fremantle (at least I'd hope for that in original fremantle as well, we definitely had it in modem firmware stack development for ALL code) | 13:42 |
| *** Martix_ has quit IRC | 13:43 | |
| *** Martix_ has joined #maemo-ssu | 13:43 | |
| DocScrutinizer05 | for kernel (and mainline system) you got that peer review on public ML where you publish your patches to get them merged | 13:50 |
| DocScrutinizer05 | for maemo core programs we need sth similar | 13:50 |
| DocScrutinizer05 | no matter which flavor/branch of maemo system, be it CSSU or even core apps shipped via extras | 13:51 |
| DocScrutinizer05 | testing QA is *way* too weak | 13:52 |
| *** l4m3rx has quit IRC | 13:57 | |
| DocScrutinizer05 | aux info: we planned 1..2h for the peer review meeting (incl notes to take, to prepare proper protocol later on) and the reviewer is supposed to use at least 4..8h to review the code before discussing it with original author in review meeting | 14:01 |
| DocScrutinizer05 | depending on result of the review meeting, a second one might be needed to review the changes that resulted from first one | 14:02 |
| Raimu | sixwheeledbeast: The replacement. | 14:03 |
| sixwheeledbeast | it's bad enough getting enough testers to QA extras-testing packages. | 14:03 |
| DocScrutinizer05 | and it's strictly forbidden to get "help" from original author during the review task, since otherwise your view on stuff gets infested with a possibly false explanation on how stuff works, given by the original author | 14:04 |
| sixwheeledbeast | Raimu: please report to ade then so it can be fixed. http://talk.maemo.org/showthread.php?t=81582 http://wiki.maemo.org/Clock_replacement | 14:05 |
| DocScrutinizer05 | sixwheeledbeast: that's not a sufficient excuse to do sloppy QA | 14:05 |
| sixwheeledbeast | didn't say it was. | 14:05 |
| DocScrutinizer05 | sixwheeledbeast: that's at best an excuse why QA takes ages until you find somebody willing and able and with the right schedule | 14:06 |
| sixwheeledbeast | ^^ was just going to say the same | 14:06 |
| DocScrutinizer05 | I'd like to suggest to create a new rule: no package/patch goes to CSSU-S without proper *documented* sourcecode peer review | 14:07 |
| DocScrutinizer05 | and a rule/guideline from industry: you may have more than just one final peer review. Actually you should discuss stuff early and frequently with your peers | 14:09 |
| DocScrutinizer05 | often even a developer team doing an almost continuous source review is more productive than two developers working solitary on their respective tasks | 14:10 |
| sixwheeledbeast | new CSSU-S is needed soon IMO. There are fixes to important things needed in Stable. A-GPS fix, hildon-desktop rotation, etc.. | 14:11 |
| DocScrutinizer05 | that however is pretty much depending on the individuals and how they "work together" | 14:11 |
| sixwheeledbeast | :nod: | 14:11 |
| DocScrutinizer05 | we should encourage teambuilding like this | 14:12 |
| DocScrutinizer05 | making peer review mandatory for CSSU-S is a first good step to encourage teambuilding | 14:12 |
| DocScrutinizer05 | yep, GPS fix is pretty important | 14:13 |
| DocScrutinizer05 | what's the rotation issue? | 14:14 |
| *** LauRoman has joined #maemo-ssu | 14:26 | |
| *** dos1 has joined #maemo-ssu | 14:31 | |
| *** dos1 has quit IRC | 14:41 | |
| *** trx has quit IRC | 14:42 | |
| *** dos1 has joined #maemo-ssu | 14:42 | |
| *** trx has joined #maemo-ssu | 14:46 | |
| *** trx has joined #maemo-ssu | 14:46 | |
| *** sono has quit IRC | 14:47 | |
| *** sono has joined #maemo-ssu | 14:47 | |
| *** Martix_ has quit IRC | 14:49 | |
| *** okias has joined #maemo-ssu | 14:51 | |
| *** KenYoung has joined #maemo-ssu | 14:52 | |
| *** freemangordon_ has joined #maemo-ssu | 15:15 | |
| *** freemangordon has quit IRC | 15:15 | |
| *** KenYoung has quit IRC | 15:31 | |
| *** Martix_ has joined #maemo-ssu | 15:42 | |
| *** NIN101 has joined #maemo-ssu | 15:48 | |
| *** Martix has joined #maemo-ssu | 15:52 | |
| *** l4m3rx has joined #maemo-ssu | 15:52 | |
| *** Martix_ has quit IRC | 15:55 | |
| *** Martix has quit IRC | 15:57 | |
| *** Martix has joined #maemo-ssu | 16:00 | |
| *** lizardo has quit IRC | 16:31 | |
| *** dhbiker has quit IRC | 16:36 | |
| *** lizardo has joined #maemo-ssu | 16:36 | |
| freemangordon_ | merlin1991: ping | 16:41 |
| *** freemangordon_ is now known as freemangordon | 16:42 | |
| merlin1991 | pong | 16:42 |
| freemangordon | merlin1991: stock glib puts .so in /usr/lib, 2-24 in /lib | 16:42 |
| freemangordon | is that a problem? | 16:42 |
| freemangordon | actually it puts libglib-2.0.so.0.2400.1 in /lib, all others in /usr/lib | 16:43 |
| freemangordon | like libgio, etc | 16:43 |
| merlin1991 | hm do you think any binary has libglib linked with an rpath? | 16:43 |
| freemangordon | it would be a madness | 16:43 |
| merlin1991 | yeah :D | 16:44 |
| *** NIN101 has quit IRC | 16:44 | |
| merlin1991 | /lib is inside the serarchpath for libs so this *should* not affect stuff | 16:44 |
| *** NIN101 has joined #maemo-ssu | 16:44 | |
| freemangordon | sure | 16:44 |
| freemangordon | but I wanted a confirmation :) | 16:44 |
| freemangordon | actually afaik /lib should be before /usr/lib | 16:45 |
| freemangordon | and it is mounted (or should be) earlier in the boot process | 16:45 |
| merlin1991 | I guess that is the reason glib is there | 16:45 |
| merlin1991 | since a lot of stuff nowadays depends at least on the memory stuff glib provides (lists and such) | 16:46 |
| freemangordon | yep, but on stock it is in /usr/lib. however, I'll leave it that way, will fix it if there is any problem | 16:46 |
| freemangordon | though I doubt there will be | 16:46 |
| *** arcean_ has joined #maemo-ssu | 17:04 | |
| *** arcean has quit IRC | 17:07 | |
| *** Martix has quit IRC | 17:23 | |
| *** Martix has joined #maemo-ssu | 17:37 | |
| sixwheeledbeast | Raimu: Thanks for bug report. I have added some links to IRC logs | 18:31 |
| *** dos1 has quit IRC | 18:34 | |
| *** dos1 has joined #maemo-ssu | 18:39 | |
| sixwheeledbeast | DocScrutinizer05: This bug fixed in Jan 2013 on CSSU-T >>> http://talk.maemo.org/showpost.php?p=1315898&postcount=1117 http://talk.maemo.org/showpost.php?p=1315929&postcount=1124 | 18:43 |
| sixwheeledbeast | I am sure there are others. | 18:43 |
| *** dos1 has quit IRC | 18:47 | |
| *** Martix has quit IRC | 18:53 | |
| arcean_ | omg | 18:56 |
| arcean_ | sixwheeledbeast: are you it's notfixed in stable? | 18:56 |
| *** nokiabot has joined #maemo-ssu | 19:22 | |
| nokiabot | where am i ?? | 19:23 |
| *** nokiabot has quit IRC | 19:23 | |
| DocScrutinizer05 | LOL | 19:26 |
| sixwheeledbeast | arcean_: AFAIK hildon-desktop on CSSU-S is later than your patch to fix above. | 19:27 |
| sixwheeledbeast | I still have this happen every now and then on CSSU-S. | 19:29 |
| *** dos1 has joined #maemo-ssu | 19:30 | |
| *** dos1 has quit IRC | 19:31 | |
| *** dos1 has joined #maemo-ssu | 19:31 | |
| *** dos1 has quit IRC | 19:43 | |
| *** dos1 has joined #maemo-ssu | 19:48 | |
| *** oldtopman has joined #maemo-ssu | 20:24 | |
| *** Martix has joined #maemo-ssu | 20:58 | |
| *** Woody14619a has joined #maemo-ssu | 21:41 | |
| *** Woody14619 has quit IRC | 21:44 | |
| *** Woody14619a is now known as Woody14619 | 21:47 | |
| *** Woody14619a has joined #maemo-ssu | 22:33 | |
| *** Woody14619 has quit IRC | 22:35 | |
| *** Martix has quit IRC | 22:56 | |
| *** lizardo has quit IRC | 22:57 | |
| *** Martix has joined #maemo-ssu | 22:59 | |
| *** arcean_ has quit IRC | 23:03 | |
| *** obiwlan has quit IRC | 23:08 | |
| *** obiwlan has joined #maemo-ssu | 23:10 | |
| *** _rd has joined #maemo-ssu | 23:27 | |
| *** nox- has joined #maemo-ssu | 23:56 | |
Generated by irclog2html.py 2.15.1 by Marius Gedminas - find it at mg.pov.lt!